Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add nix options #73

Merged
merged 7 commits into from
Mar 29, 2023
Merged

Conversation

xgroleau
Copy link
Contributor

@xgroleau xgroleau commented Mar 28, 2023

Description

Allows the user to specify options to pass to the nix command, fixes #72.

Note that the andstor/file-reader-action@v1 was replace by juliangruber/read-file-action@v1 because the old one used node 12, which is deprecated.

Changes were tested here.

Checklist
  • Tested functionality against a test repository (see "How to test changes")
  • Added or updated relevant documentation (leave unchecked if not applicable)

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but the commit summary posted in the auto-created PR body seems malformed.

action.yml Show resolved Hide resolved
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@cole-h cole-h merged commit dec3bc3 into DeterminateSystems:main Mar 29, 2023
@cole-h
Copy link
Member

cole-h commented Mar 29, 2023

(Since I just released a new version ~2 days ago, I'm going to wait until some time next week to see if any other changes are incoming.)

@xgroleau xgroleau deleted the feat/add-nix-options branch March 29, 2023 18:25
@cole-h
Copy link
Member

cole-h commented Apr 6, 2023

I just released v19 with this in it :)

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom options to nix flake command
2 participants