Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept list of reviewers and assignees #60

Conversation

EricCrosson
Copy link
Contributor

@EricCrosson EricCrosson commented Dec 26, 2022

Pass a list of GitHub usernames through to
peter-evans/create-pull-request.

Assignees are specified with the pr-assignees property.
Reviewers are specified with the pr-reviewers property.

Both properties expect the value to be a list of GitHub usernames,
separated by either commas or newlines.

Testing

Pass a list of GitHub usernames through to
peter-evans/create-pull-request.

Assignees are specified with the `pr-assignees` property.
Reviewers are specified with the `pr-reviewers` property.

Both properties expect the value to be a list of GitHub usernames,
separated by either commas or newlines.
@EricCrosson EricCrosson marked this pull request as ready for review December 26, 2022 21:38
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for letting this slip through the cracks for so long.

This looks great to me; thank you for the documentation additions and thorough testing!

@cole-h cole-h merged commit a0c5484 into DeterminateSystems:main Jan 19, 2023
@cole-h
Copy link
Member

cole-h commented Jan 19, 2023

I've tagged a release for this: https://github.com/DeterminateSystems/update-flake-lock/releases/tag/v16

@EricCrosson EricCrosson deleted the feat-accept-list-of-reviewers-and-assignees branch January 20, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants