Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit message to PR body #4

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Add commit message to PR body #4

merged 1 commit into from
Oct 19, 2021

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Oct 19, 2021

Closes #1.

@cole-h cole-h changed the title WIP: add commit message to PR Add commit message to PR body Oct 19, 2021
@cole-h
Copy link
Member Author

cole-h commented Oct 19, 2021

See cole-h/update-flake-lock-test#4 for an example of what this looks like.

cole-h
cole-h commented Oct 19, 2021
View reviewed changes
action.yml Outdated
@@ -15,10 +15,23 @@ runs:
GIT_AUTHOR_EMAIL: <github-actions[bot]@users.noreply.github.com>
GIT_COMMITTER_NAME: github-actions[bot]
GIT_COMMITTER_EMAIL: <github-actions[bot]@users.noreply.github.com>
- run: |
content="$(git log --format=%B -n 1)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GHA truncates multiline strings, so we need to escape the CR/LF characters in order for the entire commit message to be displayed.

cole-h
cole-h commented Oct 19, 2021
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@cole-h
Copy link
Member Author

cole-h commented Oct 19, 2021

cole-h/update-flake-lock-test#5 No subject!

grahamc
grahamc approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@grahamc grahamc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick!

@cole-h cole-h merged commit e26f7bb into main Oct 19, 2021
@cole-h cole-h deleted the commit_message branch October 19, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Put commit message body into PR body
2 participants
@cole-h @grahamc