Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: script for update flake lock #25

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Apr 3, 2022

Description

Take commands out of the action.yml file, and put it in a dedicated
shell script. I worked with actions recently and figured out that $GITHUB_ACTION_PATH refers to the root of the action runner, and remembered that taking the commands out of the yaml was a goal of this project.

Checklist
  • Tested functionality against a test repository (see "How to test changes")
  • Added or updated relevant documentation (leave unchecked if not applicable)

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I had no idea that env var existed! I'll take a closer look at this tomorrow, but thanks for opening this PR!

action.yml Outdated Show resolved Hide resolved
@cole-h cole-h self-assigned this Apr 4, 2022
@a-kenji
Copy link
Contributor Author

a-kenji commented Apr 5, 2022

Awesome, no rush! Yeah, I just stumbled across the variable by accident, more or less.

a-kenji and others added 2 commits April 5, 2022 08:38
Take commands out of the `action.yml` file, and put it in a dedicated
shell script.
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I pushed a commit re-adding our shellcheck CI and an action that will use ourselves to keep our own flake.lock up to date :)

Thanks a ton for reading about this env var and remembering us ❤️

@cole-h cole-h merged commit 614f33e into DeterminateSystems:main Apr 5, 2022
@a-kenji a-kenji deleted the add-shell branch April 6, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants