Convert the Action into TypeScript #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
previously requested changes
May 6, 2024
grahamc
reviewed
May 7, 2024
cole-h
reviewed
May 7, 2024
grahamc
force-pushed
the
detsys-ts
branch
2 times, most recently
from
a9e2170 to
1fd4446
Compare
cole-h
requested changes
May 9, 2024
There was a problem hiding this comment.
Doesn't seem to work as-is for me; no PR gets created.
https://github.com/cole-h/update-flake-lock-test/actions/runs/9020862190/job/24786935346 was run from the HEAD (at the time) of this branch -- notice how no PR was created, as evidenced by the lack of a number in the "echo" step:
https://github.com/cole-h/update-flake-lock-test/actions/runs/9020902721/job/24787061455 was run off of main, a PR was created, and the echo step has a PR number:
cole-h
reviewed
May 9, 2024
cole-h
reviewed
May 9, 2024
cole-h
reviewed
May 9, 2024
cole-h
approved these changes
May 9, 2024
|
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the Action to TypeScript using our
detsys-tsframework.