Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(action): update node16 to node20 #32

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

cameronraysmith
Copy link
Contributor

@cameronraysmith cameronraysmith commented Jan 24, 2024

Description

node 16 is now being deprecated relative to node 20

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: ... 
For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

using: "node16"

Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

Signed-off-by: Cameron Smith <cameron.ray.smith@gmail.com>
@cameronraysmith cameronraysmith marked this pull request as ready for review January 24, 2024 18:54
@cameronraysmith cameronraysmith marked this pull request as draft January 24, 2024 19:16
@cameronraysmith cameronraysmith marked this pull request as ready for review January 26, 2024 01:12
Copy link

@kubo6472 kubo6472 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually jumped the gun on this and thought that main will be definitely running on v20 one hour after this PR was opened. If the tests run okay...

@ConnorBaker
Copy link

@kubo6472 do you have permissions to run the test workflow? If not, who should we loop in to get this PR accepted and merged?

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems to work fine!

@cole-h cole-h merged commit eeabdb0 into DeterminateSystems:main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants