fake_auth: fix fakeidp jwt usage, take Url for issuer #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemickens
force-pushed
the
colemickens/change-fakeauth-handling
branch
from
7599fba to
2968e46
Compare
cole-h
reviewed
May 8, 2024
| pub(crate) jwt_issuer_uri: OptionString, | ||
|
|
||
| /// URL of a JWT mock server (like https://github.com/spectare/fakeidp) which can issue tokens. | ||
| pub(crate) jwt_issuer_uri: Option<url::Url>, |
There was a problem hiding this comment.
Suggested change
| pub(crate) jwt_issuer_uri: Option<url::Url>, | |
| #[clap(long)] | |
| pub(crate) jwt_issuer_uri: Option<url::Url>, |
otherwise it needs to be passed as an argument
cole-h
reviewed
May 8, 2024
| @@ -3,7 +3,7 @@ use color_eyre::eyre::{Context, Result}; | |||
| use crate::github::graphql::GithubGraphqlDataResult; | |||
|
|
|||
| pub async fn get_fake_bearer_token( | |||
| jwt_issuer_uri: &str, | |||
| jwt_issuer_uri: &url::Url, | |||
There was a problem hiding this comment.
Need to use this to set the iss claim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for changes for internal flakehub testing.
I dropped the env var / special handling. We really shouldn't be allowing this to be overriden in actions (and in fact, we already don't have a action-variable for it).
Leaving as draft, it targets the refactor branch and should co-merge with the backend change.