-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor internals, add initial gitlab support #121
Merged
Merged
+2,075
−1,413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemickens
force-pushed
the
colemickens/refactor-for-gitlab
branch
from
April 17, 2024 18:23
f44e5c1
to
4056106
Compare
cole-h
reviewed
Apr 17, 2024
src/push_context.rs
Outdated
// - also checked the graphql api pretty extensively | ||
// -- not finding anything obvious, not seeing the equivalent of the related github graphql query | ||
|
||
// spdx_expression: can't find any evidence GitLab tries to surface this info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not expecting this to be done now, but maybe we should leave a note about employing some library that allows us to detect the SPDX at least from a LICENSE{,.md}
file.
cole-h
reviewed
May 8, 2024
cole-h
reviewed
May 8, 2024
cole-h
reviewed
May 8, 2024
cole-h
reviewed
May 8, 2024
colemickens
force-pushed
the
colemickens/refactor-for-gitlab
branch
from
May 8, 2024 17:25
21e5373
to
912e883
Compare
colemickens
force-pushed
the
colemickens/refactor-for-gitlab
branch
from
May 8, 2024 21:36
912e883
to
2c53fac
Compare
cole-h
reviewed
May 8, 2024
cole-h
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit_count
given that I don't think GitLab gives us a way to get it. I think there's a small additional logic change I can make to at least makecommit_count
optional for GitLab.