Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry streams #63

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Retry streams #63

merged 1 commit into from
Sep 4, 2024

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Sep 4, 2024

Description
Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

@netlify Netlify
Copy link

netlify bot commented Sep 4, 2024 •
edited
Loading

✅ Deploy Preview for detsys-ts-docs ready!

Name Link
🔨 Latest commit e88434e
🔍 Latest deploy log https://app.netlify.com/sites/detsys-ts-docs/deploys/66d89768ae36820008d1ba1d
😎 Deploy Preview https://deploy-preview-63--detsys-ts-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cole-h
cole-h reviewed Sep 4, 2024
View reviewed changes
src/ids-host.ts Outdated Show resolved Hide resolved
@grahamc
Rework retries on streams
e88434e 
Streams can't be retried, since we open a destination and write directly to it.
Retrying the stream involves an error handler that supports resetting the stream and starting over.

This implements that.

Also:

1. Ensure we retry at least three times, regardless of how many backends are available
2. Record timings and URL information from timeout errors
3. Clean up recordEvent to not allow complex types in values to match the backend
@grahamc grahamc requested a review from cole-h September 4, 2024 17:24
cole-h
cole-h reviewed Sep 4, 2024
View reviewed changes
src/index.ts Show resolved Hide resolved
@grahamc grahamc merged commit 65dd73c into main Sep 4, 2024
5 checks passed
@grahamc grahamc deleted the retry-streams branch September 4, 2024 18:04
This was referenced Sep 4, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

@colemickens colemickens colemickens approved these changes

@lucperkins lucperkins lucperkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grahamc @colemickens @lucperkins @cole-h