Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

update + experimental gold decisions #91

Closed
wants to merge 4 commits into from
Closed

update + experimental gold decisions #91

wants to merge 4 commits into from

Conversation

RomeoAlphaEkko
Copy link
Contributor

updates:

  • dragon - wont reroll anymore (pro saves gold / con no automatic mission anymore
  • xp - will now buy xp -> Enhancement: “Buy XP” Enhancement: “Buy XP” #75
  • death - icon play till 0 hp
  • new 1-1 carussel position -- item collection didnt work before
  • screenshot for ok button

experimental:

@Detergent13
Copy link
Owner

This looks super cool but I really don't have the time to do proper testing for it. If anybody has tried it out, please let me know how the stability is!

Also I would rather not have the experimental features (gold related) in the main branch, I'd be willing to make an experimental branch if you want though? I think stability is one of the most important things, especially for something that you'd expect to run in the background for even days at a time.

I'm generally against adding too many bells and whistles for that reason, but the non-experimental changes seem very reasonable to merge.

Thank you again for your contributions!

@RomeoAlphaEkko
Copy link
Contributor Author

Hi,
it runs stable, you. (that is tested)

the main point would be like over"blocking" the wrong recognition, 9 and sometimes 8 gets seen as 0
and sometimes it still rerolls even though it should not (having enough gold to reroll but not enough to use the shop afterwards)

@Kyrluckechuck Kyrluckechuck mentioned this pull request Oct 23, 2022
Merged
Kyrluckechuck added a commit to Kyrluckechuck/TFT-Bot that referenced this pull request Oct 25, 2022
@Kyrluckechuck
Merge pull request #1 from Kyrluckechuck/near-rewrite
667240b 
Rewrote most of the logic, reorganized the images & included things from Detergent13#91

Key Changes:
- Argument parsing
  - Add `--ffearly` when running to forfeit early
  - Initial verbosity enablement (`-v`/`--verbose`)
    - To be updated further to actually utilize this setting
- Re-add `Exit Now` detection for when you are eliminated (non-winning / early ff scenarios)
- Path in counter-clockwise diamond for shared draft stages
- Gold logic for smarter decisions / less invalid clicks
- Ability to pause/resume bot using `Alt+P`
- Ability to restart bot mid-match

Complete Code Overhaul:
- Event-loop based architecture (instead of event-bubbling based)
- Reorg imports
- Introduce "constants" style paths, allowing cleaner re-use
@RomeoAlphaEkko
Copy link
Contributor Author

@Kyrluckechuck
as you use different versions if trying it out, will it break this version? aka update requirements

@Kyrluckechuck
Copy link

@RomeoAlphaEkko
As long as you run a pip install -r requirements.txt before running either this branch or my branch, the requirements shouldn't break?

But in terms of compatibility, this branch/code will likely not merge/rebase cleanly with the changes I made since I've overhauled nearly the entire repo -- no worries though for now since I don't want to merge my fork upstream unless @Detergent13 decides they want that, again since it's nearly an entire rewrite and fairly decently more complicated than this in both in terms of code complexity and functionality

@Detergent13
Copy link
Owner

If you want to use these changes, please check out @Kyrluckechuck's fork at https://github.com/Kyrluckechuck/TFT-Bot! It's orders of magnitude more feature-rich than my original.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomeoAlphaEkko @Detergent13 @Kyrluckechuck