Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly attach column/header classes in the column definition #10954

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

bhollis
Copy link
Contributor

@bhollis bhollis commented Feb 17, 2025

The Organizer is set up a bit weirdly today - classes are implicitly attached to columns by name, which makes it difficult to keep track of what's used where. We also attach the entire cell class to the column headers, which is rarely appropriate. This also makes it hard to reuse one class across multiple columns.

This PR changes to having an explicit className and headerClassName property on each column that we can assign from a CSS module import, just like all our other classes.

@bhollis bhollis merged commit 282fd90 into master Feb 17, 2025
7 checks passed
@bhollis bhollis deleted the attach-column-classes branch February 17, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant