Nuked notable gender-setting code

With the introduction of unique notables, this code doesn't seem like a good idea anymore. You are free to change their gender and name via another mod.
Designer225 · Mar 2, 2023 · 23b12c0 · 23b12c0
1 parent 56c844b
commit 23b12c0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/FixedBanditSpawning/LocationCharacterConstructorPatch.cs b/FixedBanditSpawning/LocationCharacterConstructorPatch.cs
@@ -153,15 +153,6 @@ public static bool Prepare()
 
         public static void Postfix(ref Hero __result)
         {
-            //var faction = __result.MapFaction;
-            // It appears that gang leaders, merchants, and preachers have some female representation. Will skip them in that case.
-            if ((__result.IsArtisan || __result.IsRuralNotable || __result.IsHeadman) && !__result.IsFemale)
-            {
-                __result.UpdatePlayerGender(MBRandom.RandomFloat < D225MiscFixesSettingsUtil.Instance.WorkerGenderRatio);
-                NameGenerator.Current.GenerateHeroNameAndHeroFullName(__result, out var firstName, out var fullName, false);
-                __result.SetName(fullName, firstName);
-            }
-
             AgeModel ageModel = Campaign.Current.Models.AgeModel;
             int baseAge = Math.Max(ageModel.HeroComesOfAge, LocationCharacterConstructorPatch.TweenAge);
             if (__result.IsNotable)

diff --git a/SubModule.xml b/SubModule.xml
@@ -1,7 +1,7 @@
 <Module>
   <Name value="Designer225's Miscellaneous Fixes"/>
   <Id value="FixedBanditSpawning"/>
-  <Version value="v1.1.16.82"/>
+  <Version value="v1.1.17.90"/>
   <SingleplayerModule value="true"/>
   <MultiplayerModule value="false"/>
   <Official value="false"/>