BSDFMaterial properties can now be accessed from Lua #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the given argument for the BSDFMaterial setter is nil/no value, then it will instead act as a getter.
Derpius
requested changes
Sep 19, 2022
There was a problem hiding this comment.
In addition to the one review comment, you can use LUA->Top() (possibly GetTop) to check if the number of items on the stack is 0
The roughness function should return the linear value. It's more likely that a user is getting material properties to save/reapply later or to use in their own shading algorithms, than to plug it straight back into GGX
Also you don't need to set each vector field manually, there's a MakeVector function in the utils for this very purpose
Derpius
added
enhancement
Also use MakeVector instead of manually constructing a Vector
Derpius
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59.
PR Type (tick all that are applicable)
Tested Targets (only applicable for changes to the binary module, delete otherwise)
Checklist
Description
If the given argument for the BSDFMaterial setter is nil/no value, then it will instead act as a getter and return the currently set value.
Here's the only odd example with this PR.
Instead of returning the linear roughness that was given to the setter, the getter will instead return the raw roughness. This behavior sounds correct to me, but any comments on this? It may be confusing to users who aren't aware.