fix(ast): Add database name to object_reference #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional database name to the object_reference rule and add some tests to add the new functionality
|
Resolves #310 not sure if there's a cleaner way to do the rule in the tree-sitter grammer, my solution is a little in-elegant. Let me know if you want me to change anything/add tests/change tests/etc. |
|
Realized I didn't take care of some of the steps in the contributing.md like the version bump. Sorry will do tomorrow |
DerekStride
approved these changes
Mar 11, 2025
|
We do adhoc releases at the moment so the version bump isn't necessary unless you'd like us to publish a new version to npm, crates, or pypi. That can be in a follow-up PR if you like – this one looks great, thank you 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional database name to the object_reference rule and add some tests to add the new functionality