Missing CREATE, ALTER DROP statement #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthias-Q
force-pushed
the
missing_cruds
branch
from
350a365 to
cd3cf05
Compare
matthias-Q
force-pushed
the
missing_cruds
branch
from
cd3cf05 to
56e6d6b
Compare
dmfay
reviewed
Aug 2, 2023
matthias-Q
commented
Aug 2, 2023
dmfay
reviewed
Aug 3, 2023
dmfay
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
CREATE,ALTER,DROPfor:sequencedatabaseuser,group,roleindex(onlyalter)This is quite a lot but very repetitive. Unfortunately, many times it is just 80% reusable code and many dialect specific keyword. I have tried to find a balance.
I noticed that we still miss a lot of basic statements. I will add an issue for that. it would have been to much to put it in here as well.