Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tsql multiple add columns in alter statement #175

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

matthias-Q
Copy link
Collaborator

Closes #135 and supersedes #144

I feel this is a bit hacky, but I just made the add keyword optional, so that it will not repeated in _alter_specifications

I also removed that rename part of the test, since this is not valid SQL syntax and made the keyword constrain optional. See discussion in #144

@matthias-Q matthias-Q requested review from dmfay and DerekStride July 3, 2023 17:57
Copy link
Collaborator

@dmfay dmfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a venial kludge at worst imo but a TODO comment above add_column might be a good idea in case we wind up revisiting

@matthias-Q matthias-Q merged commit a3c5bc8 into DerekStride:main Jul 4, 2023
@matthias-Q matthias-Q deleted the tsql_alter_table_2 branch July 4, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

T-SQL Alter Table
3 participants