Get self reference modules working

[MylesBorins]

I was partially confused due to a potential spec bug
in package.exports that didn't take into account top-level
application (without a . main)

This now works and has a passing test.

Refs: nodejs/node#30633

[DerekNonGeneric]

@MylesBorins, I cloned your branch and ran the test locally. It is failing on my machine. Could this have to do with the ~/package.json hack? (I don't have one.)

[MylesBorins]

That is exactly why it is failing. Have not figured out why that breaks it yet... Definitely a weirdo bug

…

On Mon, Nov 25, 2019, 3:20 AM Derek Lewis ***@***.***> wrote: @MylesBorins <https://github.com/MylesBorins>, I cloned your branch and ran the test locally. It is failing on my machine. Could this have to do with the ~/package.json hack? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADZYV3V2HZ57TI6VF3EDADQVODFDANCNFSM4JREVJUA> .

[DerekNonGeneric]

I will take it from here and investigate further, thanks!

[fusionstrings]

Hi @MylesBorins and @DerekNonGeneric

I ended up here while following the trails of LOAD_SELF_REFERENCE from here https://nodejs.org/dist/latest-v13.x/docs/api/modules.html and nodejs/node#31009

I was looking into the implementation to get help on my quest to get 'self reference" working from here https://github.com/MylesBorins/lorem-demo/tree/fc5ed2558670028e3c5bb02f2ae098044d63212a

The implementation uses --no-esm and test fails in absence of it. Does it mean that self resolution is non-ESM feature?

[DerekNonGeneric]

Hello @fusionstrings, glad you found your way here!

Does it mean that self resolution is non-ESM feature?

Nope, it definitely works with import too!

Here's a brief explanation that might help clarify what's being described above.

The --no-esm flag disables '-r esm' behavior by switching off the --esm flag, which is on by default. This '-r esm' behavior would preload the esm module at startup. The esm, module, which is a userland loader to polyfill versions of Node.js without native support for ES Modules, is no longer necessary in v13.2+. This is because the majority of the ES module implementation is unflagged in the 13.x release line.

I would recommend checking out the master branch of this repository (the one attached to this thread) to see a currently functional implementation. Just make sure you're on v13.2+. It should be working! I know how confusing this can be, so I've dropped some links below that I hope will clarify what I've written above. Ultimately, the cause of it not working on my end was that the integrated VSCode terminal, which I was using to test this behavior, was using the wrong version.

Let me know if there's anything else. :)

• --no-esm §
• -r, --require module §
• esm, module §
• v13.2 Unflagging announcement §

Note: the esm module does not put your code in module context. It is still in commonjs context, and I would advise against using it if you are interested in testing the new ES module implementation.

[fusionstrings]

Thanks a lot @DerekNonGeneric for explaining in detail especially about significance of --no-esm.

I got it working now 👍

[MylesBorins]

One thing to add --no-esm is a tap specific flag... Not for the nodejs runtime

…

On Mon, Feb 24, 2020, 7:04 AM Dilip Kr. Shukla ***@***.***> wrote: Thanks a lot @DerekNonGeneric <https://github.com/DerekNonGeneric> for explaining in detail especially about significance of --no-esm. I got it working now 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AADZYV3KAKQ74KVDIHEWY43REOZVPA5CNFSM4JREVJUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMXRQYA#issuecomment-590288992>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADZYVYPQTXNIRUDPNBNNN3REOZVPANCNFSM4JREVJUA> .

[fusionstrings]

@MylesBorins Thanks for clarifying.

The issue with me was extremely weird. I matched with the code in master branch of https://github.com/DerekNonGeneric/loader339 and my code was using same convention.

As @DerekNonGeneric mentioned that he was using VSCode integrated terminal, so was I.
I use nvm and ensured correct version was activated.

I still can't figure out what was wrong 😢but a restart seems to have fixed it for me.
Assurance that master branch has working code ensured that something is wrong from my side.