And some more classes have changed in the header #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
freewil
reviewed
Aug 24, 2017
src/header.css
Outdated
| @@ -19,6 +19,10 @@ | |||
| color: #555 | |||
| } | |||
|
|
|||
| .great-header .notification-indicator { | |||
| color: #4078c0; | |||
There was a problem hiding this comment.
I think this should be #555 or a similar neutral gray to match the other icons. There is a separate blue icon if you have any notifications.
There was a problem hiding this comment.
Thanks for the feedback. I did wonder about that when I wrote it.
I have now styled it #333 and blue on hover, just like the other links in the header and the + icon beside it.
joeytwiddle
force-pushed
the
fix-header-classes
branch
from
6643b98 to
b0ad4bb
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today:
The
.headerclass turned into.Header. (But in this PR I actually ignore the class and target theheadertag instead.)The
.header-navlinkwhich we got a few weeks ago has now become.HeaderNavlinkThe notification indicator (bell icon) has become light grey. So when we make the header white, I make the indicator
classic bluedark grey.Users of the Chrome extension are currently getting this error:
Cannot read property 'classList' of nulland none of the greatness.