Skip to content

Commit

Permalink
Extend the dispatch table for H5FD back to version 1.13.2
Browse files Browse the repository at this point in the history
re: Issue Unidata#2634
re: PR Unidata#2615
re: Issue Unidata#2614

It turns out that the H5FD table change identified in
issue Unidata#2614
actually occurred in HDF5 version 1.13.2.
Since we do not test with 1.13.x, we did not catch this.
  • Loading branch information
DennisHeimbigner committed Feb 22, 2023
1 parent 0034e31 commit 8556a9d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This file contains a high-level description of this package's evolution. Release

* Fix 'make distcheck' error in run_interop.sh. See [Github #????](https://github.com/Unidata/netcdf-c/pull/????).
* Update `nc-config` to remove inclusion from automatically-detected `nf-config` and `ncxx-config` files, as the wrong files could be included in the output. This is in support of [GitHub #2274](https://github.com/Unidata/netcdf-c/issues/2274).
* Update H5FDhttp.[ch] to work with HDF5 version 1.14.0. See [Github #2615](https://github.com/Unidata/netcdf-c/pull/2615).
* Update H5FDhttp.[ch] to work with HDF5 version 1.13.2 and later. See [Github #????](https://github.com/Unidata/netcdf-c/pull/????).

## 4.9.1 - February 2, 2023

Expand Down
6 changes: 3 additions & 3 deletions libhdf5/H5FDhttp.c
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ static herr_t H5FD_http_unlock(H5FD_t *_file);

/* Beware, not same as H5FD_HTTP_g */
static const H5FD_class_t H5FD_http_g = {
#if H5_VERSION_GE(1,14,0)
#if H5_VERSION_GE(1,13,2)
H5FD_CLASS_VERSION, /* struct version */
H5_VFD_HTTP, /* value */
#endif
Expand Down Expand Up @@ -195,7 +195,7 @@ static const H5FD_class_t H5FD_http_g = {
H5FD_http_get_handle, /* get_handle */
H5FD_http_read, /* read */
H5FD_http_write, /* write */
#if H5_VERSION_GE(1,14,0)
#if H5_VERSION_GE(1,13,2)
NULL, /* read_vector */
NULL, /* write_vector */
NULL, /* read_selection */
Expand All @@ -205,7 +205,7 @@ static const H5FD_class_t H5FD_http_g = {
NULL, /* truncate */
H5FD_http_lock, /* lock */
H5FD_http_unlock, /* unlock */
#if H5_VERSION_GE(1,14,0)
#if H5_VERSION_GE(1,13,2)
NULL, /* del */
NULL, /* ctl */
#endif
Expand Down

0 comments on commit 8556a9d

Please sign in to comment.