Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specialize the executable for the current device #3

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

georgepaw
Copy link
Collaborator

No description provided.

Copy link
Owner

@DenisVieriu97 DenisVieriu97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good

@DenisVieriu97 DenisVieriu97 merged commit df7cb59 into DenisVieriu97:main Nov 18, 2023
18 of 44 checks passed
@georgepaw georgepaw deleted the dev/georgep/package branch November 20, 2023 11:46
DenisVieriu97 added a commit that referenced this pull request Nov 26, 2023
Co-authored-by: Denis Vieriu <104024078+DenisVieriu97@users.noreply.github.com>
DenisVieriu97 added a commit that referenced this pull request Nov 30, 2023
Co-authored-by: Denis Vieriu <104024078+DenisVieriu97@users.noreply.github.com>
DenisVieriu97 added a commit that referenced this pull request Nov 30, 2023
* Fix mps_executor_runner build when using cmake

* Add CI scripts to run supported executorch networks through MPS (#1)

* Add CI scripts to run supported executorch networks through MPS

* Fix CI

* Fix CI #2

* Don't specialize the executable for the current device (#3)

Co-authored-by: Denis Vieriu <104024078+DenisVieriu97@users.noreply.github.com>

* Update CI script to run test_mps (#4)

* Update CI script to run test_mps

* Update cmdline

* Add lint for mps

* Update lint script

* Update lint script

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Add support for conv1D (fixes w2l)

* Perf imprv - Map conv2D to depthwiseConv3D

* Add support for PyTorch style printing of output tensors

* Fix lint

* Remove unused headers

* Remove unused headers #2

---------

Co-authored-by: Grzegorz George Pawelczak <grzpawelczak@gmail.com>
DenisVieriu97 added a commit that referenced this pull request Dec 1, 2023
Co-authored-by: Denis Vieriu <104024078+DenisVieriu97@users.noreply.github.com>
DenisVieriu97 added a commit that referenced this pull request Dec 1, 2023
* Fix mps_executor_runner build when using cmake

* Add CI scripts to run supported executorch networks through MPS (#1)

* Add CI scripts to run supported executorch networks through MPS

* Fix CI

* Fix CI #2

* Don't specialize the executable for the current device (#3)

Co-authored-by: Denis Vieriu <104024078+DenisVieriu97@users.noreply.github.com>

* Update CI script to run test_mps (#4)

* Update CI script to run test_mps

* Update cmdline

* Add lint for mps

* Update lint script

* Update lint script

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Add support for conv1D (fixes w2l)

* Perf imprv - Map conv2D to depthwiseConv3D

* Add support for PyTorch style printing of output tensors

* Fix lint

* Remove unused headers

* Remove unused headers #2

---------

Co-authored-by: Grzegorz George Pawelczak <grzpawelczak@gmail.com>
DenisVieriu97 added a commit that referenced this pull request Dec 12, 2023
Co-authored-by: Denis Vieriu <104024078+DenisVieriu97@users.noreply.github.com>
DenisVieriu97 added a commit that referenced this pull request Dec 12, 2023
* Fix mps_executor_runner build when using cmake

* Add CI scripts to run supported executorch networks through MPS (#1)

* Add CI scripts to run supported executorch networks through MPS

* Fix CI

* Fix CI #2

* Don't specialize the executable for the current device (#3)

Co-authored-by: Denis Vieriu <104024078+DenisVieriu97@users.noreply.github.com>

* Update CI script to run test_mps (#4)

* Update CI script to run test_mps

* Update cmdline

* Add lint for mps

* Update lint script

* Update lint script

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Add support for conv1D (fixes w2l)

* Perf imprv - Map conv2D to depthwiseConv3D

* Add support for PyTorch style printing of output tensors

* Fix lint

* Remove unused headers

* Remove unused headers #2

---------

Co-authored-by: Grzegorz George Pawelczak <grzpawelczak@gmail.com>
DenisVieriu97 added a commit that referenced this pull request Jan 19, 2024
Co-authored-by: Denis Vieriu <104024078+DenisVieriu97@users.noreply.github.com>
DenisVieriu97 added a commit that referenced this pull request Jan 19, 2024
* Fix mps_executor_runner build when using cmake

* Add CI scripts to run supported executorch networks through MPS (#1)

* Add CI scripts to run supported executorch networks through MPS

* Fix CI

* Fix CI #2

* Don't specialize the executable for the current device (#3)

Co-authored-by: Denis Vieriu <104024078+DenisVieriu97@users.noreply.github.com>

* Update CI script to run test_mps (#4)

* Update CI script to run test_mps

* Update cmdline

* Add lint for mps

* Update lint script

* Update lint script

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Add support for conv1D (fixes w2l)

* Perf imprv - Map conv2D to depthwiseConv3D

* Add support for PyTorch style printing of output tensors

* Fix lint

* Remove unused headers

* Remove unused headers #2

---------

Co-authored-by: Grzegorz George Pawelczak <grzpawelczak@gmail.com>
DenisVieriu97 pushed a commit that referenced this pull request Aug 9, 2024
Summary:
Pull Request resolved: pytorch#4127

The convention in most files is:
1. Related header
2. Headers of the form ".h" (i.e. this project's other headers, further organize into blocks according to directory)
3. Headers of the form <> (i.e. standard libraries' headers)

This change organizes files violating this convention by resolving #3.
ghstack-source-id: 232399398
exported-using-ghexport

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: SS-JIA

Differential Revision: D59282477

fbshipit-source-id: 29e0ece657c9bae05a3072594e57e57db92be2b3
DenisVieriu97 added a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants