Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved comments and logging #17

Merged
merged 17 commits into from
Mar 14, 2023
Merged

Conversation

crichgriffin
Copy link
Contributor

@crichgriffin crichgriffin commented Mar 14, 2023

Actual code changes:

  • fixed r_path in the pipeline scripts

  • fixed parsing of the booleans in the argument parsing (some were still being parsed as strings)
    Here is an example change:
    parser.add_argument('--use_muon', default=False, type=check_for_bool, help='')
    instead of
    parser.add_argument('--use_muon', default=False, help='')
    and below in the script check_for_bool(args.use_muon) (this bit got forgotten sometimes)

Logging improvements:

Copy link
Contributor Author

@crichgriffin crichgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have double checked all of these files

@crichgriffin crichgriffin self-assigned this Mar 14, 2023
@crichgriffin crichgriffin added the bug Something isn't working label Mar 14, 2023
@crichgriffin crichgriffin merged commit 3271464 into DendrouLab:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[preprocess] how to run pre-filtered objects
2 participants