dont allow to register fb users without email Closes #1001

DemocracyOS · Aug 6, 2015 · 43aeb5d · 43aeb5d
1 parent 39a1794
commit 43aeb5d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/auth-facebook/strategy.js b/lib/auth-facebook/strategy.js
@@ -20,7 +20,12 @@ module.exports = function() {
       User.findByProvider(profile, function (err, user) {
         if (err) return done(err);
 
-        if (!user) return signup(profile, accessToken, done);
+        if (!user) {
+          if (!profile.emails) {
+            return done(new Error(t('signup.facebook.need-email-error')));
+          }
+          return signup(profile, accessToken, done);
+        }
 
         var email = profile._json.email;
         if (user.email !== email) {

diff --git a/lib/translations/lib/en.json b/lib/translations/lib/en.json
@@ -283,6 +283,7 @@
   "signup.email": "Email",
   "signup.email-sent": "Email sent",
   "signup.email-validated": "Your email has been validated and now you are logged in",
+  "signup.facebook.need-email-error": "To signup you need to have configured an email on your facebook account.",
   "signup.firstname": "Firstname",
   "signup.go-to": "Go to",
   "signup.lastname": "Lastname",