Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Network model #871

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Remove Network model #871

merged 2 commits into from
Apr 8, 2024

Conversation

savente93
Copy link
Contributor

@savente93 savente93 commented Apr 8, 2024

Issue addressed

Fixes #817

Explanation

We currently don't have an implementation or a model to base a potential implementations on, so it doens't make much sense to keep this around until we do. Therefore it's better to remove it it and work on it when we have an actual use case. As we haven't been touching the main documentation throughout v1 I haven't updated it there either, we will tackle that when we adress the documentation more directly .

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed
  • For predefined catalogs: update the catalog version in the file itself, the references in data/predefined_catalogs.yml, and the changelog in data/changelog.rst

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@savente93 savente93 marked this pull request as ready for review April 8, 2024 08:39
Copy link
Contributor

@hboisgon hboisgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@savente93 savente93 merged commit 795af3d into v1 Apr 8, 2024
8 checks passed
@savente93 savente93 deleted the remove-network-model branch April 8, 2024 08:46
@savente93 savente93 linked an issue Apr 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NetworkModelComponent class
2 participants