Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extreme value statistics #85

Merged
merged 17 commits into from
Jul 18, 2023
Merged

extreme value statistics #85

merged 17 commits into from
Jul 18, 2023

Conversation

DirkEilander
Copy link
Contributor

@DirkEilander DirkEilander commented Jan 13, 2022

This PR adds new statistical methods based on xarray.DataArrays to

  • Detect peaks in timeseries data
  • Fit commonly applied extreme value distributions (Gumbel, GEV, Gen Pareto) based on lmoments (which is not available in scipy). Select optimal distribution based on AIC, AICc or BIC
  • Derive averaged peak hydrograph shape from timeseries
  • Derive itensity-duration-frequency (IDF) curves from rainfall timeseries
  • Derive hyetograph using the alternating block method from IDF curves
  • Extreme value plot utilities

TODO

  • tests
  • docs

@DirkEilander DirkEilander linked an issue Jul 14, 2023 that may be closed by this pull request
12 tasks
@DirkEilander
Copy link
Contributor Author

DirkEilander commented Jul 14, 2023

Brief summary of discussion with @couasnonanais

The current implementation fills the following gaps:

  • lmoments based eva
  • that can be applied on ND grids

Alternatives

  • pyextremes Has more functionality, but limited to single timeseries and requires np.datetime64_ns index which limits the length of timeseries
  • xclim The functionality similar or less to our implementation, could potentially also work on ND grids (not tested)

TODO (Dirk):

  • discuss how it compares to those other packages in the example
  • finish test test_eva_idf
  • finish review

@DirkEilander DirkEilander marked this pull request as ready for review July 14, 2023 13:18
Copy link
Contributor

@savente93 savente93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ITY

@savente93 savente93 merged commit 849bcc4 into main Jul 18, 2023
8 checks passed
@savente93 savente93 deleted the eva branch July 18, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Missing test units for eva branch - stats folder
3 participants