Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode debugging #807

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Vscode debugging #807

merged 2 commits into from
Mar 4, 2024

Conversation

deltamarnix
Copy link
Contributor

  • Make it possible to debug pytest unit tests via vs code. I needed to set up a purpose in the launch.json.
  • Share settings about auto-formatting that is workspace specific.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed
  • For predefined catalogs: update the catalog version in the file itself, the references in data/predefined_catalogs.yml, and the changelog in data/changelog.rst

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@Jaapel
Copy link
Contributor

Jaapel commented Mar 1, 2024

Do we want to share settings for code editors? Because this feels like a personal preference to me. I use mostly vscode, but I know others do not. You can always propose these in the developer docs.

@deltamarnix
Copy link
Contributor Author

Do we want to share settings for code editors? Because this feels like a personal preference to me. I use mostly vscode, but I know others do not. You can always propose these in the developer docs.

I believe in a uniform environment for all developers. The settings that I have shared are settings that are mandatory for the respository. We use linting and pre-commits anyways, where autoformatting is done in the same way.

A developer can always override these settings with personal settings. Visual Studio caters multiple layers of settings:

image

@savente93
Copy link
Contributor

I don't use vscode, but honestly, vscode is popular (and uniform) enough that I think it makes sense to include it. Especially if it helps people get setup faster and avoids support issues because our setup doesn't work for people. Something like vim is too personalized to support defaults for I think, but for vscode it makes sense even though I personally dislike it ;P

@deltamarnix deltamarnix merged commit 9869e06 into main Mar 4, 2024
2 checks passed
@deltamarnix deltamarnix deleted the vscode-debugging branch March 4, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants