Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for clipping on bbox for rotated dask arrays #801

Merged
merged 6 commits into from
Feb 29, 2024
Merged

fix for clipping on bbox for rotated dask arrays #801

merged 6 commits into from
Feb 29, 2024

Conversation

roeldegoede
Copy link
Contributor

Issue addressed

Fixes #800

Explanation

If it is a dask array, min and max values can only be determined with the compute() function.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed
  • For predefined catalogs: update the catalog version in the file itself, the references in data/predefined_catalogs.yml, and the changelog in data/changelog.rst

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@roeldegoede roeldegoede mentioned this pull request Feb 27, 2024
Closed
2 tasks
@DirkEilander DirkEilander merged commit e420c5c into Deltares:main Feb 29, 2024
9 checks passed
@roeldegoede roeldegoede deleted the fix_clip_bbox_rotated branch March 12, 2024 14:18
@savente93 savente93 mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirkEilander DirkEilander DirkEilander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

raster.clip_bbox doesn't work for (rotated) dask arrays
2 participants
@roeldegoede @DirkEilander