Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: support data like objects in DataCatalog.get methods #313

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

DirkEilander
Copy link
Contributor

@DirkEilander DirkEilander added Enhancement New feature or request DataCatalog & DataAdapters issues related to the DataCatalog and DataAdapters labels Apr 3, 2023
@DirkEilander
Copy link
Contributor Author

@B-Dalmijn or @Tjalling-dejong could one of you review this PR? See attached issue for more background.

Copy link
Contributor

@Tjalling-dejong Tjalling-dejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DirkEilander
Copy link
Contributor Author

failing tests are the result of pandas 2.0 in combination with xarray. This shoud be resolved soon at xarray see pydata/xarray#7716

@DirkEilander DirkEilander merged commit 4266d3f into main Apr 5, 2023
@DirkEilander DirkEilander deleted the flex_data_adapter branch April 5, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataCatalog & DataAdapters issues related to the DataCatalog and DataAdapters Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: enable in-memory data to be passed to data source arguments in setup methods
2 participants