-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved flw.d8_from_dem
method
#305
Conversation
@DirkEilander are you still interested in this functionality? If so I'd urge you to try to get this merged because the further we get with v1 the harder it will be to integrate down the line |
Thanks for the reminder. Yes, this functionality should land in HydroMT. I'll try to squeeze it in some time soon |
flw.d8_from_dem
method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that we can use something else than upstream area to burn rivers in the DEM!
PR looks good, just one small check if outlets
= idxs_pit
that this indeed works with pyflwdir but else can be merged :)
Co-authored-by: hboisgon <45457510+hboisgon@users.noreply.github.com>
I wanted to make it more explicit here what option is selected. I should do the same in pyflwdir. But it already works because in pyflwdir I only check for the outlets="min" case. |
No description provided.