Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dei 176 automated container publish to ghcr #113

Merged
merged 107 commits into from
Jul 1, 2024

Conversation

CindyvdVries
Copy link
Collaborator

No description provided.

@MAfarrag
Copy link
Contributor

as I see the manual trigger workflow_dispatch is empty in the docker_image.yml workflow so we can not test this workflow manually now before we merge this pull request to main? or how can we test it ?

@CindyvdVries
Copy link
Collaborator Author

as I see the manual trigger workflow_dispatch is empty in the docker_image.yml workflow so we can not test this workflow manually now before we merge this pull request to main? or how can we test it ?

Yes this is the problem of this issue. We can't test without making changes in the code unfortunately. I can add a on 'push' for this workflow and then we can test the workflow_dispatch inside the branch (the button for manual triggering will appear in the github actions). So we can test it, but before squash and merge we need to remove this again. (But same goes for checking the whole workflow, before merging we need to reset the versions again... see comment in JIRA).

Copy link

sonarcloud bot commented Jul 1, 2024

@CindyvdVries CindyvdVries merged commit 6969d4b into main Jul 1, 2024
7 checks passed
@CindyvdVries CindyvdVries deleted the feature/DEI-176-automated-container-publish-to-ghcr branch July 1, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants