Dead Man's Signaller #2775
Merged
Dead Man's Signaller #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
|
RSI Diff Bot; head commit 5262b89 merging into 19a58d8 Resources/Textures/_DV/Objects/Devices/deadmanssignaller.rsi
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
deltanedas
requested changes
Jan 20, 2025
Content.Server/DeltaV/DeviceLinking/Systems/DeadMansSignallerSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeviceLinking/Components/DeadMansSignallerComponent.cs
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Devices/Electronics/signaller.yml
Outdated
Show resolved
Hide resolved
Resources/Textures/Objects/Devices/deadmanssignaller.rsi/meta.json
Outdated
Show resolved
Hide resolved
|
I really hope this doesn't break everything |
… into Dead-man's-switch # Conflicts: # Resources/Locale/en-US/_DV/store/uplink-catalog.ftl # Resources/Prototypes/_DV/Catalog/uplink_catalog.yml # Resources/Prototypes/_DV/Entities/Objects/Devices/Electronics/dead-mans-signaller.yml
|
I love this idea. But i can't wait for a glimmer discharge to blow up the hostage. |
deltanedas
requested changes
Jan 20, 2025
Content.Server/DeltaV/DeviceLinking/Systems/DeadMansSignallerSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/DeltaV/DeviceLinking/Systems/DeadMansSignallerSystem.cs
Outdated
Show resolved
Hide resolved
Content.Server/_DV/DeviceLinking/Components/DeadMansSignallerComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/_DV/DeviceLinking/Components/DeadMansSignallerComponent.cs
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Devices/Electronics/signaller.yml
Outdated
Show resolved
Hide resolved
Resources/Textures/_DV/Objects/Devices/deadmanssignaller.rsi/meta.json
Outdated
Show resolved
Hide resolved
|
Direction reviewing, should be about 24 hours! |
|
Direction approved! The increased range is fine, since it's already a more advanced tech, and we're not too worried about price meta since it's already cheap and nondestructive by itself. Signaller is a fine name for it since it's in the family of all the other signallers. Looking forward to see how people use it. |
deltanedas
requested changes
Jan 22, 2025
Content.Server/_DV/DeviceLinking/Components/DeadMansSignallerComponent.cs
Outdated
Show resolved
Hide resolved
Content.Server/_DV/DeviceLinking/Components/DeadMansSignallerComponent.cs
Show resolved
Hide resolved
Content.Server/_DV/DeviceLinking/Systems/DeadMansSignallerSystem.cs
Outdated
Show resolved
Hide resolved
deltanedas
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Added a new signaller that when dropped, will send a signal to anything it's connected to.
Why / Balance
Meant to be used for hostage situations and will hopefully provide higher quality RP for those, but it could theoretically be used for any number of things.
Technical details
Is available in the syndicate uplink and as part of the same research as the advanced signaller. Costs 2 TC in uplink, can be discounted to 1 TC (Would like feedback on this). The sprite changes when activated, and it has increased range like the advanced signaller (Want feedback on this too). Uses ItemToggle for activation. Let me know if you prefer it being called signaller or switch.
Media
Base.Profile.2025.01.19.-.11.47.10.01.mp4
Requirements
Breaking changes
I don't think there's any but uhh the signaller system could possibly break stuff? It shouldn't.
Changelog
🆑