-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add surgeon access & role #2645
Add surgeon access & role #2645
Conversation
Meow 24 hours for direction review |
7d091f2
to
db307c0
Compare
Should get a surgeon locker that can contain all the tools they need as well as some general surgeon work apparel. |
Honestly, I think making surgery the responsibility of a separate role is a bad idea. As far as medical roles go, medical doctor has always had the short end of the stick--every single other medical role can do everything a medical doctor does, so their only real defining feature is that you're supposed to stay in medbay all shift. As is, a medbay can run just fine without any medical doctors, which feels strange. Making surgery a separate access is something I'm 100% in support of though--it'd be great to have surgery off limits to roles that aren't medical doctors, so that the entire rest of med isn't literally doctor+ in terms of what they're capable of doing, and give something unique to the medical doctor role. (Also, if we ever get ss13-style wound med, then med emphasizes surgery far more and we'd probably have to combine medical doctor and surgeon back together because otherwise there's not much someone without surgery access can do) |
Being mechanically able to do a job is different from being supposed to do it. |
Resources/Prototypes/Entities/Objects/Devices/Electronics/door_access.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Misc/identification_cards.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Tools/access_configurator.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Tools/access_configurator.yml
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ff681e9
to
d9fe28f
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
d9fe28f
to
b6f4319
Compare
surgeon locker prototype is added, feel free to nit the contents |
Nit picks incoming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks
63150f2
to
26835f7
Compare
26835f7
to
507892e
Compare
Resources/Prototypes/_DV/Entities/Structures/Doors/Airlocks/access.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_DV/Entities/Structures/Storage/Closets/Lockers/lockers.yml
Outdated
Show resolved
Hide resolved
109e579
to
6ee8dca
Compare
6ee8dca
to
dee838d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! Looking forward to seeing this in game, thank you for the work out in.
About the PR
This adds a surgeon role and separate surgery access.
Why / Balance
Given the potential damage that can be inflicted by surgery, it makes sense both in-character that NanoTrasen would hire different specialities for e.g. someone who is trained in surgery vs someone that's good at being a paramedic, as well as out-of-character, where surgery could potentially be used to break several server rules therefore it makes sense for admins to have a way to roleban someone from the role with access to it.
This also allows for surgeons to have a specific job title, icon, PDA, and loadout that allows them to be immediately distinct from the rest of the medical crew. From "surgeons injure people if they aren't wearing gloves and mask" it follows that having a surgeon's loadout mandate these makes sense.
Technical details
Media
Requirements
Changelog
🆑