Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Purchasable Arena Mob Crates #2563

Merged
merged 16 commits into from
Jan 7, 2025

Conversation

IamVelcroboy
Copy link
Member

@IamVelcroboy IamVelcroboy commented Dec 30, 2024

About the PR

  • Adds 3 constructable plasteel livestock crates (standard, secure, reinforced secure)
  • Adds 2 arena mob crates for sale in cargo (small mob, large mob)

Why / Balance

For purchase in Arena station (or potentially other makeshift arena/entertainment situations)

Technical details

Arena mob crates are armory locked

Media

Screenshot 2024-12-30 103335

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an in-game showcase.

Breaking changes

n/a

Changelog
🆑 Velcroboy

  • add: Additional aggressive mobs can now be purchased for Arena Station. Caution is advised.

@IamVelcroboy IamVelcroboy requested review from a team as code owners December 30, 2024 17:20
@github-actions github-actions bot added S: Needs Review size/L 256-1023 lines Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Dec 30, 2024
Copy link
Contributor

github-actions bot commented Dec 30, 2024

RSI Diff Bot; head commit 221a14f merging into b0965ed
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Structures/Storage/Crates/livestock_reinforced.rsi

State Old New Status
DamageOverlay_75 Added
base Added
closed Added
icon Added
locked Added
open Added
sparking Added
unlocked Added
welded Added

Resources/Textures/_DV/Structures/Storage/Crates/livestock_secure.rsi

State Old New Status
base Added
closed Added
icon Added
locked Added
open Added
sparking Added
unlocked Added
welded Added

Resources/Textures/_DV/Structures/Storage/Crates/livestock_steel.rsi

State Old New Status
base Added
closed Added
icon Added
open Added
welded Added

Edit: diff updated after 221a14f

@Radezolid
Copy link
Contributor

Holy shit, thanks. No more faxing CC for more mobs.

@Avalon-Proto
Copy link
Contributor

Initial infected gonna go crazy with these :blunt:

@deltanedas
Copy link
Member

cargo fishops and xeno agent gameplay

@IamVelcroboy IamVelcroboy requested a review from a team as a code owner December 31, 2024 16:57
@github-actions github-actions bot added the Changes: C# Changes any cs files label Dec 31, 2024
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 1, 2025
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 1, 2025
Lyndomen
Lyndomen previously approved these changes Jan 3, 2025
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion to add many small mobs to the big crate too as a rare chance.

Killer tomato's should also move up 1, but is also fine as is if it's meant to be a bad option :p

@Avalon-Proto
Copy link
Contributor

Here's my question- can we link these up to some kind of signal to remotely open them? Not sure the secoff wants to be right next to the crate containing a dangerous mob

@IamVelcroboy
Copy link
Member Author

Here's my question- can we link these up to some kind of signal to remotely open them? Not sure the secoff wants to be right next to the crate containing a dangerous mob

Let me look into it...not sure though...maybe could steel some door code. Otherwise, It's like, unlock them and run away and let the gladiators open the door 😄

@IamVelcroboy
Copy link
Member Author

Small suggestion to add many small mobs to the big crate too as a rare chance.

Main issue is lots of duplication. I guess I could just pick 1 mob from each group(carp, snake, etc) and make it a group in the large crate.

Killer tomato's should also move up 1, but is also fine as is if it's meant to be a bad option :p

Not sure what you mean by "up 1" Should I increase the number of them?

@Lyndomen
Copy link
Contributor

Lyndomen commented Jan 3, 2025

Small suggestion to add many small mobs to the big crate too as a rare chance.

Main issue is lots of duplication. I guess I could just pick 1 mob from each group(carp, snake, etc) and make it a group in the large crate.

Killer tomato's should also move up 1, but is also fine as is if it's meant to be a bad option :p

Not sure what you mean by "up 1" Should I increase the number of them?

Yeah exactly, killer tomato's are dogshit tier so prolly wanna throw some more in the mix

Lyndomen
Lyndomen previously approved these changes Jan 7, 2025
@IamVelcroboy
Copy link
Member Author

Oh, damn it. I had some test stuff still in there

@Lyndomen Lyndomen self-requested a review January 7, 2025 18:52
@IamVelcroboy IamVelcroboy merged commit 838ca86 into DeltaV-Station:master Jan 7, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants