Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stock market refactor #2141

Merged
merged 11 commits into from
Jan 1, 2025
Merged

stock market refactor #2141

merged 11 commits into from
Jan 1, 2025

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Nov 7, 2024 •
edited
Loading

About the PR

  • renamed StockCompanyStruct to StockCompany, it didnt need Struct in its name. classes dont have Class in their name etc
  • made MarketChange a struct
  • instead of 2 copy paste functions to buy and sell, just TryChangeStocks that handles negatives to sell
  • log the user instead of loader since you can steal pdas

@github-actions github-actions bot added Changes: UI Changes: C# Changes any cs files labels Nov 7, 2024
@MilonPL
Copy link
Member

MilonPL commented Nov 7, 2024 •
edited
Loading

FUCK it only took 2 days (why didn't you stop me)

@MilonPL
Copy link
Member

MilonPL commented Nov 7, 2024

@deltanedas while you're at it, something that probably should've been done but I didn't think about, is also playing the deny sound if TryChangeStocks fails, to give player feedback in case we can't afford it or we don't have enough stocks to sell

@github-actions github-actions bot added the size/M 64-255 lines label Nov 29, 2024
@deltanedas deltanedas marked this pull request as ready for review November 29, 2024 09:54
@deltanedas deltanedas requested a review from a team as a code owner November 29, 2024 09:54
MilonPL
MilonPL suggested changes Nov 29, 2024
View reviewed changes
Content.Server/DeltaV/Cargo/Systems/StockMarketSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Cargo/Systems/StockMarketSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Cargo/Systems/StockMarketSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Cargo/Systems/StockMarketSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Cargo/Systems/StockMarketSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Cargo/Systems/StockMarketSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Cargo/Systems/StockMarketSystem.cs Outdated Show resolved Hide resolved
Content.Server/DeltaV/Cargo/Systems/StockMarketSystem.cs Outdated Show resolved Hide resolved
@deltanedas deltanedas force-pushed the market-manipulation-ops branch from e9847bc to ee46fef Compare November 29, 2024 19:50
@deltanedas deltanedas requested a review from MilonPL December 10, 2024 20:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 1, 2025
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 1, 2025
@deltanedas deltanedas merged commit 8360e71 into DeltaV-Station:master Jan 1, 2025
12 checks passed
@deltanedas deltanedas deleted the market-manipulation-ops branch January 1, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilonPL MilonPL Awaiting requested review from MilonPL

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: UI S: Needs Review size/M 64-255 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deltanedas @MilonPL