Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packing Justice's lunch #2111

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

Monotheonist
Copy link
Contributor

@Monotheonist Monotheonist commented Nov 4, 2024

About the PR

Fixes #1341. Packs Justice a lunch. Did you know the only locker this is applicable to is the Clerk? It should be noted that if Prosecutor or Clerk is axed, someone should reuse the locker in some shape because I cannot give Prosecutors, CJs, or Attorneys a lunch. Therefore, this might need to be mapped in, or Prosecutors and Attorneys might need to have custom lockers.

Why / Balance

They deserve to have a lunch packed for them. They have families. It would greatly affect game balance because justice would not go hungry and therefore would be less mean to sec because their brain isn't angry because they have not had food all day.

Technical details

YAML and sprites.

Media

image
This has inhand sprites and open sprites, you can see the rest in the diff / changes made section of this PR. I simply followed how it was done in the last lunchboxes PR.

Requirements

Breaking changes

Changelog

🆑

  • add: Justice has lunch packed for them, millions of attorneys must not go hungry.

@Monotheonist Monotheonist requested review from IamVelcroboy and a team as code owners November 4, 2024 05:25
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi labels Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

RSI Diff Bot; head commit 7343f93 merging into 358a795
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Storage/lunchbox.rsi

State Old New Status
justice-inhand-left Added
justice-inhand-right Added
justice-open Added
justice Added

Edit: diff updated after 7343f93

@deltanedas deltanedas enabled auto-merge (squash) November 7, 2024 09:22
@deltanedas deltanedas merged commit 5c9edab into DeltaV-Station:master Nov 7, 2024
13 checks passed
@Monotheonist Monotheonist deleted the justice-lunch-ops branch December 7, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Justice Department doesn't have a lunchbox
2 participants