Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adds the fire-fighting door remote and modifies it. #2007

Merged

Conversation

Radezolid
Copy link
Contributor

@Radezolid Radezolid commented Oct 14, 2024

About the PR

I added the fire-fighting control back, which still spawns inside atmospheric technicians lockers, but now you can hack firelocks either to remove the bolt or to trigger it.

Why / Balance

Controlling gas leaks and superheated air becomes difficult to control with people just barging in without a care.
The removal was made at a time where the remotes used the accessGroup + the user's ID, so stealing AA made this control really overpowered.

Technical details

Altered YAML to add the fire fighting remote back and place them at the atmospheric technicians lockers. Added wires to the firelocks.

Media

2024-10-14.00-51-53.mp4

Requirements

Breaking changes

Hopefully none.

Changelog

🆑

  • add: Re-added the fire-fighting door remote to atmospheric technicians lockers, but it only has maintenance access now.

@Radezolid Radezolid requested a review from a team as a code owner October 14, 2024 03:56
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files and removed S: Needs Review labels Oct 14, 2024
@deltanedas
Copy link
Member

i believe the goob pr adds wires to firelocks so it can be countered by hacking

@Radezolid
Copy link
Contributor Author

i believe the goob pr adds wires to firelocks so it can be countered by hacking

IMO, firelocks shouldn't be able to be hacked since they are supposed to be a bit like dumb doors, and removing the bolting on them was fair i guess.

@Radezolid
Copy link
Contributor Author

To help prove my point:
image

People just kept opening firelocks and due to a person going to maints the tritium fire expanded outwards and forcing the station to evacuate due to the death of the crew.

The current "solution" to prevent people from walking in these areas is holofan (you get 6 charges per medium battery) and welding which is out of the question on plasma or tritium leaks like this one.

Copy link
Member

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firelocks need to have a bolt wire if we want to re-add the remote.

@Radezolid
Copy link
Contributor Author

Demonstration of the wire additions:

2024-10-30.10-30-28.mp4

@deltanedas deltanedas added S: Awaiting Changes Do not merge due to requested changes and removed S: Needs Review labels Nov 3, 2024
@Radezolid Radezolid requested a review from deltanedas November 3, 2024 23:50
@github-actions github-actions bot added S: Needs Review and removed S: Awaiting Changes Do not merge due to requested changes labels Nov 3, 2024
MilonPL
MilonPL previously requested changes Nov 4, 2024
Resources/Prototypes/Catalog/Fills/Lockers/engineer.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Catalog/Fills/Lockers/engineer.yml Outdated Show resolved Hide resolved
@deltanedas deltanedas merged commit 1e7a830 into DeltaV-Station:master Nov 4, 2024
13 checks passed
@Radezolid Radezolid deleted the Revert-firefight-control-removal branch November 5, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants