Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

ERT Overhaul #170

Merged
merged 11 commits into from
Sep 22, 2023
Merged

ERT Overhaul #170

merged 11 commits into from
Sep 22, 2023

Conversation

Tryded
Copy link
Contributor

@Tryded Tryded commented Sep 5, 2023

Overhauling ERTs that admemes can spawn.
Mostly Admeme QoL.

About the PR

Completely Overhauls the Emergency Response Teams based off of Paradise Station's Wiki, dividing them into 3 levels, Amber, Red, and Gamma.
https://paradisestation.org/wiki/index.php?title=Emergency_Response_Team
Amber has no hardsuits and the ERT members are basically just like their job but a bit better.
Red and Gamma gets hardsuits and Gamma Level has multiple experimental equipment for when everything goes wrong.
This could allow admins to quickly set up Emergency Response Teams of their choosing while not running the risk of losing extremely overpowered gear.
Hopefully this would allow deployment of ERTs to ease times of crisis, for example during a mass bombing crisis and majority of the engineering department is dead or incompetent, instead of letting the station burn to the ground Central command would send an Amber ERT instead until the crisis is averted.
Media
2023-9-05_16 15 45

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

The Errors.. make them stop.
@github-actions github-actions bot added the No C# label Sep 5, 2023
@Tryded
Copy link
Contributor Author

Tryded commented Sep 5, 2023

Currently having problems with some ERT members missing bags and belts

Accidental Capitalization and copying mistakes.
@Tryded
Copy link
Contributor Author

Tryded commented Sep 5, 2023

What does " 1) CLIENT: 0.223s [ERRO] root: Predicting the queued deletion of a networked entity: observer (27313, MobObserver). Trace: at System.Environment.get_StackTrace()
It is the only failure in Build & Test Debug / build (ubuntu-latest) (pull request)

@Colin-Tel
Copy link
Contributor

What does " 1) CLIENT: 0.223s [ERRO] root: Predicting the queued deletion of a networked entity: observer (27313, MobObserver). Trace: at System.Environment.get_StackTrace() It is the only failure in Build & Test Debug / build (ubuntu-latest) (pull request)

image

Tests sometimes will fail for something completely unrelated to your changes.

@Tryded
Copy link
Contributor Author

Tryded commented Sep 6, 2023

Welp time to wait for review

@DEATHB4DEFEAT
Copy link
Member

Changelogs are unnecessary unless ERT is done without admin intervention now and I didn't notice

@Tryded
Copy link
Contributor Author

Tryded commented Sep 8, 2023

Ah well, do I just delete them from existence?

Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SS13's Amber alert is pretty much equivalent to SS14's Red alert, and we don't have an Amber alert, so maybe shift the names around

@DEATHB4DEFEAT
Copy link
Member

Ah well, do I just delete them from existence?

Make sure the changes are covered in the PR description and you can delete the CL

@Tryded
Copy link
Contributor Author

Tryded commented Sep 8, 2023

Amber is a custom name made for ERTs that are meant to more of give the station more personnel to help solve their problems, like a relief team.

SS13's Amber alert is pretty much equivalent to SS14's Red alert, and we don't have an Amber alert, so maybe shift the names around

@Tryded
Copy link
Contributor Author

Tryded commented Sep 8, 2023

Amber is a custom name made for ERTs that are meant to more of give the station more personnel to help solve their problems, like a relief team.

SS13's Amber alert is pretty much equivalent to SS14's Red alert, and we don't have an Amber alert, so maybe shift the names around

This is why they aren't armed to the teeth compared to the others. only enough to do their jobs.

@Tryded
Copy link
Contributor Author

Tryded commented Sep 9, 2023

If anyone wants to add code so that different types of ERTs can be called via Comms console, be my guest.

@DebugOk
Copy link
Contributor

DebugOk commented Sep 9, 2023

If anyone wants to add code so that different types of ERTs can be called via Comms console, be my guest.

Code like that will not be merged now or at any point in the future. Hard no.

@Tryded
Copy link
Contributor Author

Tryded commented Sep 9, 2023

If anyone wants to add code so that different types of ERTs can be called via Comms console, be my guest.

Code like that will not be merged now or at any point in the future. Hard no.

Well, is this PR by itself fine? It only makes it so admenes can deploy ERTs easier without risking the loss of valuable equipment.

@Tryded
Copy link
Contributor Author

Tryded commented Sep 10, 2023

If anyone wants to add code so that different types of ERTs can be called via Comms console, be my guest.

Code like that will not be merged now or at any point in the future. Hard no.

Well, it probably won't get coded, however I do want to know any objections with this PR

@Tryded
Copy link
Contributor Author

Tryded commented Sep 11, 2023

Note: This PR is mostly just for admene QoL, it does not have anything that makes ERT spawn able without admin intervention.

@Tryded
Copy link
Contributor Author

Tryded commented Sep 21, 2023

I wonder if this has a chance of getting approved

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Sep 21, 2023
@Tryded
Copy link
Contributor Author

Tryded commented Sep 21, 2023

pls review /hj

@DEATHB4DEFEAT
Copy link
Member

the hell does /hj mean

@Tryded
Copy link
Contributor Author

Tryded commented Sep 22, 2023

the hell does /hj mean
half joking, eh probably shouldn't use it on github or something.

Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me.

@Tryded
Copy link
Contributor Author

Tryded commented Sep 22, 2023

Looks alright to me.

So approved?

@DEATHB4DEFEAT DEATHB4DEFEAT enabled auto-merge (squash) September 22, 2023 01:36
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@DEATHB4DEFEAT DEATHB4DEFEAT merged commit 0f4ec57 into DeltaV-Station:master Sep 22, 2023
@Tryded Tryded deleted the ERT-Overhaul branch September 22, 2023 02:04
DebugOk added a commit that referenced this pull request Sep 26, 2023
@DebugOk DebugOk mentioned this pull request Sep 26, 2023
DebugOk added a commit that referenced this pull request Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants