Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added get_child_folder_ids_by_folderid #45

Closed
wants to merge 2 commits into from

Conversation

AndriiHoropatskyiDelinea
Copy link
Contributor

No description provided.

@delinea-sagar
Copy link
Member

@AndriiHoropatskyiDelinea Test case is getting fail for your new function. I think you are using wrong API endpoint to getting child folders. In current code you have invoked search_secret() function but this function is used to get secret details not folder details. You need to introduce new function like search_folder() which will return details then you can get child folders details by passing query parameter getAllChildren=true to this function. Also in param["Take"] parameter need to get child folders count. For more details please refer secret server REST API doc (Folder section). Your endpoint should be "{self.api_url}/folders/id" which will return all child folders array when getAllChildren=true in query param.

@SimHeb
Copy link

SimHeb commented Mar 4, 2024

Hi @AndriiHoropatskyiDelinea,

any news on that? Can I help out somewhere?

@AndriiHoropatskyiDelinea
Copy link
Contributor Author

Hi @AndriiHoropatskyiDelinea,

any news on that? Can I help out somewhere?

Hi. Yes, these are your changes, but the tests did not work in the previous PR because the secrets are not available for the fork. Therefore, you can edit the code in my branch and supplement this PR.

@SimHeb
Copy link

SimHeb commented May 10, 2024

@AndriiHoropatskyiDelinea, This can be closed, I created a new PR here.

@tylerezimmerman tylerezimmerman deleted the ah-childFolder branch June 28, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants