d3-dsv and d3-request #10947
Merged
d3-dsv and d3-request #10947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* d3-dsv: Added new definitions and tests correspondinf to d3-dsv module (v 1.0.1) of D3 version 4. Moved legacy definitions and tests into new sub folder v0. These are no longer relevant, as they do not reflect d3-dsv package at all. There should be no dependencies on them. * d3-request: Added definitions for module and related shape tests.
|
For reference: This PR is related to Definitions Request #9936 . |
This was referenced Sep 1, 2016
|
@andy-ms @RyanCavanaugh @mhegazy can someone pleeeeease merge this PR? If there is any change required, please advise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially replaces the now closed PR #10453. It is a follow-up to the clarification in the New Contribution/Transition Issues Thread #10711 with respect to legacy definitions.
@RyanCavanaugh @andy-ms thanks for looking into getting this one moved through. The predecessor PR had been in limbo for a while, due to the legacy issue.
This PR no longer contains d3 Standard Bundle definitions to avoid the hold-up related to legacy versions. The legacy definitions of d3-dsv is no longer relevant, as it does not correspond to d3-dsv. There should be no DefinitelyTyped dependencies on it.
@Ledragon this is a re-submission of d3-dsv and d3-request as discussed. No changes from the current version on d3-v4-definitelytyped.
cc @gustavderdrache
Add a new type definition.
--target es6and--noImplicitAnyoptions.-tests.tsor-tests.tsx.