Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AIA workflow to automate MSI/EXE binary creation #50

Closed
3 tasks done
DefinetlyNotAI opened this issue Sep 2, 2024 · 0 comments · Fixed by #52
Closed
3 tasks done

Add AIA workflow to automate MSI/EXE binary creation #50

DefinetlyNotAI opened this issue Sep 2, 2024 · 0 comments · Fixed by #52
Assignees
@DefinetlyNotAI
Labels
progress:Won't Fix (Could be disputed) This will not be worked on, further info will be added to why, To dispute comment on the issue. request:Important New feature or request, top priority, for next update type:System Related to System Code for Logicytics

Comments

@DefinetlyNotAI
Copy link
Owner

Prerequisites

Proposal

Use this to add workflow bot

Motivation and context

No response

What is the importance for implementing this idea?

High
@DefinetlyNotAI DefinetlyNotAI self-assigned this Sep 2, 2024
@DefinetlyNotAI DefinetlyNotAI added request:Important New feature or request, top priority, for next update progress:WIP Currently Working on this, Next update will result in the fix of this issue. labels Sep 2, 2024
@DefinetlyNotAI DefinetlyNotAI mentioned this issue Sep 2, 2024
Merged
11 tasks
DefinetlyNotAI added a commit that referenced this issue Sep 2, 2024
@DefinetlyNotAI
Create AIP_Maker.yml bot (#51)
06a0185 
### Description

<!-- Describe your changes in detail -->

### Motivation & Context

<!-- Why is this change required? What problem does it solve? -->

### Type of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Refactoring (non-breaking change)
- [ ] Breaking change (fix or feature that would change existing
functionality)
- [ ] My change introduces changes to the documentation (only docs are
affected)

### Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have read the [contributing
guidelines](https://github.com/DefinetlyNotAI/Logicytics/blob/main/CONTRIBUTING.md)
- [x] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes, and they have passed
- [ ] I have tested my code with the `--dev` flag
- [ ] I have followed the instructions in the `--dev` flag
- [x] I have followed the instructions in the
[wiki](https://github.com/DefinetlyNotAI/Logicytics/wiki)

### Related issues

#50
DefinetlyNotAI added a commit that referenced this issue Sep 2, 2024
@DefinetlyNotAI
Added AIP -> #50
6cb64dc
DefinetlyNotAI added a commit that referenced this issue Sep 2, 2024
@DefinetlyNotAI
Fixed default packages-> #50
77ca20a
DefinetlyNotAI added a commit that referenced this issue Sep 2, 2024
@DefinetlyNotAI
Bug fix for FUNDING.yml -> #50
f933af0
DefinetlyNotAI added a commit that referenced this issue Sep 2, 2024
@DefinetlyNotAI
JsonSchema Updated -> #50
e4690ed
@DefinetlyNotAI DefinetlyNotAI linked a pull request Sep 2, 2024 that will close this issue
50 add aia workflow to automate msiexe binary creation #52
Merged
11 tasks
@DefinetlyNotAI DefinetlyNotAI mentioned this issue Sep 2, 2024
Merged
11 tasks
DefinetlyNotAI added a commit that referenced this issue Sep 2, 2024
@DefinetlyNotAI
50 add aia workflow to automate msiexe binary creation (#52)
9a0d7f7 
### Description

Fixing #50 and implementing #26 

### Motivation & Context

LOL

### Type of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Refactoring (non-breaking change)
- [ ] Breaking change (fix or feature that would change existing
functionality)
- [ ] My change introduces changes to the documentation (only docs are
affected)

### Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have read the [contributing
guidelines](https://github.com/DefinetlyNotAI/Logicytics/blob/main/CONTRIBUTING.md)
- [x] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes, and they have passed
- [ ] I have tested my code with the `--dev` flag
- [ ] I have followed the instructions in the `--dev` flag
- [x] I have followed the instructions in the
[wiki](https://github.com/DefinetlyNotAI/Logicytics/wiki)

### Related issues
#50 and #26
@DefinetlyNotAI DefinetlyNotAI reopened this Sep 2, 2024
@DefinetlyNotAI DefinetlyNotAI added progress:Won't Fix (Could be disputed) This will not be worked on, further info will be added to why, To dispute comment on the issue. and removed progress:WIP Currently Working on this, Next update will result in the fix of this issue. labels Sep 2, 2024
DefinetlyNotAI added a commit that referenced this issue Sep 2, 2024
@DefinetlyNotAI
Delete IMG/ClickMe.jpg (#53)
2a12866 
body:
  - type: checkboxes
    attributes:
      label: Prerequisites
description: Take a couple minutes to help our maintainers work faster
by checking of the pre-requisites.
      options:
- label: I have
[searched](https://github.com/DefinetlyNotAI/Logicytics/pulls) for
duplicate or closed issues.
          required: true
- label: I have read the [contributing
guidelines](https://github.com/DefinetlyNotAI/Logicytics/blob/main/CONTRIBUTING.md).
          required: true
- label: I have followed the instructions in the
[wiki](https://github.com/DefinetlyNotAI/Logicytics/wiki) about
contributions.
          required: true
- label: I have updated the documentation accordingly, if required (If
not leave this unchecked)
          required: false
- label: I have added tests to cover my changes, and they have passed,
if required (If not leave this unchecked)
          required: false
- label: I have tested my code with the `--dev` flag, if required (If
not leave this unchecked)
          required: false
- label: I have followed the instructions in the `--dev` flag, if
required (If not leave this unchecked)
          required: false
  - type: checkboxes
    attributes:
      label: PR_Type
description: Take a couple minutes to help our maintainers work faster
by telling us what is the PR guided on.
      options:
        - label: Bug fix (non-breaking change which fixes an issue)
          required: false
- label: New feature (non-breaking change which adds functionality)
          required: false
        - label: Refactoring (non-breaking change)
          required: false
- label: Breaking change (fix or feature that would change existing
functionality)
          required: false
- label: My change introduces changes to the documentation (only docs
are affected)
  - type: textarea
    id: description
    attributes:
      label: Describe the PR
description: Provide a summary of the pr and what you expected to
happen.
    validations:
      required: true
  - type: textarea
    id: motivation-context
    attributes:
      label: Motivation and Context
      description: Why is this PR required? What problem does it solve?
    validations:
      required: true
  - type: input
    id: issues
    attributes:
      label: What issues will be fixed?
placeholder: "Please link any related issues here. Give them in this
format `#50, #23` etc"
    validations:
      required: true
@DefinetlyNotAI DefinetlyNotAI closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2024
@DefinetlyNotAI DefinetlyNotAI added the type:System Related to System Code for Logicytics label Sep 18, 2024
DefinetlyNotAI added a commit that referenced this issue Sep 24, 2024
@DefinetlyNotAI
Made the build process faster by ~50% (#113)
8b35a12 
## Pull Request Template

### Prerequisites

<!-- Take a couple of minutes to help our maintainers work faster by
checking of the pre-requisites. -->
<!-- To tick the checkboxes replace the space with an 'x', so [ ]
becomes [x] . -->

- [x] I have
[searched](https://github.com/DefinetlyNotAI/Logicytics/pulls) for
duplicate or closed issues.
- [x] I have read the [contributing
guidelines](https://github.com/DefinetlyNotAI/Logicytics/blob/main/CONTRIBUTING.md).
- [x] I have followed the instructions in the
[wiki](https://github.com/DefinetlyNotAI/Logicytics/wiki) about
contributions.
- [x] I have updated the documentation accordingly, if required.
- [ ] I have added tests to cover my changes, and they have passed, if
required.
- [ ] I have tested my code with the `--dev` flag, if required.

### PR Type

<!-- Take a couple of minutes to help our maintainers work faster by
telling us what is the PR guided on. -->
<!-- To tick the checkboxes replace the space with an 'x', so [ ]
becomes [x] . -->

- [ ] Bug fix <!-- Non-Breaking Bug Fix - Usually relates to fixing an
issue -->
- [ ] New feature <!-- Non-Breaking Change that adds a new feature -->
- [x] Refactoring <!-- Non-Breaking Change that modifies existing code
to refactor it to become more organised -->
- [ ] Documentation
update <!-- Non-Breaking Change that modifies existing documentation to
refactor it or add extra comments - either wiki, md files or code is
included here -->
- [ ] ⚠️ Breaking change ⚠️ <!-- Breaking Bug Fix / New Addition that
changes how Logicytics works -->

### Description

AIP now is faster by ~50% by making builds able to be duo-build on exe
and msi - So from 8 separate build, to 4 separate builds

### Motivation and Context

To increase development speed

### Binaries

<!-- If you have any binaries built from the AIP, Upload them here -->
<!-- OPTIONAL for patch updates - To leave empty just type _N/A_ -->
Already linked

### Credit

<!-- If this PR is a contribution, please mention the contributors here
using the appropriate syntax. -->

_N/A_

<!--
### File-Created/CONTRIBUTION by MAIN-Username
What you did, created, removed, refactored, fixed, or discovered.
- [Your GitHub Username](https://github.com/YourGitHubLink)
- [Your GitHub Username](https://github.com/YourGitHubLink) etc...
-->

### Issues Fixed

<!-- REQUIRED: What issues will be fixed? (Format: "#50, #23" etc.) if
none exist type _N/A_ -->

_N/A_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DefinetlyNotAI DefinetlyNotAI

Labels
progress:Won't Fix (Could be disputed) This will not be worked on, further info will be added to why, To dispute comment on the issue. request:Important New feature or request, top priority, for next update type:System Related to System Code for Logicytics
Projects
Issue Board
Status: Rejected / Duplicate
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

50 add aia workflow to automate msiexe binary creation DefinetlyNotAI/Logicytics
1 participant
@DefinetlyNotAI