Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter format is removed, now dart format #168

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Flutter format is removed, now dart format #168

merged 7 commits into from
Oct 7, 2024

Conversation

IanVS
Copy link
Contributor

@IanVS IanVS commented Sep 27, 2024

It was removed in 3.12: flutter/flutter#129360

This updates the README and our CI job.

@IanVS
Copy link
Contributor Author

IanVS commented Sep 27, 2024

Alright good, the latest commit shows that it's working, we do indeed have one file that is not correctly formatted.

jasikpark
jasikpark previously approved these changes Sep 27, 2024
Copy link
Contributor

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IanVS IanVS mentioned this pull request Oct 1, 2024
Base automatically changed from java-update to master October 7, 2024 12:22
@IanVS IanVS dismissed jasikpark’s stale review October 7, 2024 12:22

The base branch was changed.

@IanVS IanVS requested review from jasikpark and johnmaguire October 7, 2024 12:22
@IanVS IanVS merged commit cc0ee7c into master Oct 7, 2024
2 checks passed
@IanVS IanVS deleted the ci-build branch October 7, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants