Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android dependencies and AGP #165

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Update Android dependencies and AGP #165

merged 7 commits into from
Sep 26, 2024

Conversation

IanVS
Copy link
Contributor

@IanVS IanVS commented Sep 26, 2024

This updates kotlin, gson, AGP, and WorkManager to the latest versions.

It also updates the README to include the correct ndk version for our AGP, as specified here: https://developer.android.com/build/releases/gradle-plugin#compatibility

image

Lastly it adds a bit of safety around registerReceiver calls, to satisfy a lint warning, and updates our copyright date.

Copy link
Member

@johnmaguire johnmaguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@@ -98,7 +98,12 @@ class MainActivity: FlutterActivity() {

apiClient = APIClient(context)

registerReceiver(refreshReceiver, IntentFilter(ACTION_REFRESH_SITES), RECEIVER_NOT_EXPORTED)
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol Android is the worst

@IanVS IanVS merged commit 2b900fe into master Sep 26, 2024
2 checks passed
@IanVS IanVS deleted the update-ndk branch September 26, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants