Update Flutter, target android SDK 34 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we've gotten to a new enough version of flutter that it doesn't break
Otherwise we get a build error
Some material elements, like AdaptiveSwitch, won't work in iOS without it.
|
|
jasikpark
previously approved these changes
Sep 19, 2024
johnmaguire
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Consider doing dart fmt separately and adding the hash to .git-blame-ignore-revs. We haven't done this for all of them, but they can be pretty major, as in this PR...
Looks like go get ran, so maybe run go mod tidy as well to clean up superfluous items in go.sum.
|
Mind running |
I assumed that's what happened when I ran |
johnmaguire
approved these changes
Sep 20, 2024
|
Thanks for the review John. Let's hold off on a release / beta build for now, there's a bit more that I nearly have ready to push up. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates flutter to 3.24.1, the latest stable version, and also updates our flutter dependencies to latest.
It targets the latest android sdk, 34, which is required if we want to publish a new version to the Google Play store.
I also needed to make a few adjustments to handle deprecations. The biggest change is that I needed to wrap the main widget in
MaterialAppto avoid problems with AdaptiveSwitch in iOS.