Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff: add and fix EM rules #9892

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Ruff: add and fix EM rules #9892

merged 4 commits into from
Apr 30, 2024

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Apr 8, 2024

Copy link

dryrunsecurity bot commented Apr 8, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Configured Codepaths Analyzer 0 findings
Sensitive Files Analyzer 0 findings
AppSec Analyzer 0 findings
Authn/Authz Analyzer 32 findings
Secrets Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Powered by DryRun Security

@kiblik kiblik closed this Apr 8, 2024
@kiblik kiblik reopened this Apr 8, 2024
@kiblik kiblik marked this pull request as ready for review April 8, 2024 16:50
Copy link
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor typos/style suggestions. Sorry to bug you with these, but linter PRs seem like a good opportunity to resolve them.

dojo/tools/api_sonarqube/api_client.py Outdated Show resolved Hide resolved
dojo/tools/factory.py Outdated Show resolved Hide resolved
dojo/tools/threagile/parser.py Outdated Show resolved Hide resolved
dojo/tools/yarn_audit/parser.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

kiblik and others added 2 commits April 30, 2024 16:51
Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
kiblik and others added 2 commits April 30, 2024 16:51
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mtesauro mtesauro merged commit 1c9c74e into DefectDojo:dev Apr 30, 2024
123 checks passed
@kiblik kiblik deleted the ruff_em branch April 30, 2024 20:42
dogboat pushed a commit to dogboat/django-DefectDojo that referenced this pull request May 6, 2024
* Ruff: add and fix EM rules

Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>

* Update dojo/tools/api_sonarqube/api_client.py

Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>

* Update dojo/tools/factory.py

Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>

* Clean newline

---------

Signed-off-by: kiblik <5609770+kiblik@users.noreply.github.com>
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants