Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Nancy Parser #9801

Merged
merged 12 commits into from
Mar 26, 2024
Merged

Implement Nancy Parser #9801

merged 12 commits into from
Mar 26, 2024

Conversation

grendel513
Copy link
Contributor

@grendel513 grendel513 commented Mar 21, 2024

JSON file parser for the Nancy scanner: https://github.com/sonatype-nexus-community/nancy

[sc-4916]

@github-actions github-actions bot added settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR docs unittests parser labels Mar 21, 2024
Copy link

dryrunsecurity bot commented Mar 21, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Sensitive Functions Analyzer 0 findings
Configured Sensitive Files Analyzer 0 findings
Sensitive Files Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Tip

Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example...

@dryrunsecurity What are common security issues with web application cookies?

Powered by DryRun Security

Copy link
Contributor

@cneill cneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor suggestions here

dojo/tools/nancy/parser.py Outdated Show resolved Hide resolved
dojo/tools/nancy/parser.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

grendel513 and others added 2 commits March 21, 2024 14:12
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
@grendel513
Copy link
Contributor Author

Just a couple minor suggestions here

thank you @cneill - committed your suggestions

@Maffooch Maffooch changed the title [sc-4916] first commit, nancy parser Implement Nancy Parser Mar 25, 2024
@devGregA devGregA merged commit 09189d9 into DefectDojo:dev Mar 26, 2024
121 checks passed
manuel-sommer pushed a commit to manuel-sommer/django-DefectDojo that referenced this pull request Mar 27, 2024
* [sc-4916] first commit, nancy parser

* remanged __init__.py

* removed unused import

* invalid has field

* unittests

* unittests

* doc file name

* Update dojo/tools/nancy/parser.py

Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>

* Update dojo/tools/nancy/parser.py

Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>

* Update settings.dist.py

missing comma

* conflict

---------

Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs parser settings_changes Needs changes to settings.py based on changes in settings.dist.py included in this PR unittests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants