Endpoints: Remove "verified" query on listing pages #9717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Tip Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example... Powered by DryRun Security |
blakeaowens
approved these changes
Mar 11, 2024
grendel513
approved these changes
Mar 11, 2024
cneill
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with endpoints, I thought it was a little misleading that findings needed to be verified to be counted on a given endpoint/host. A finding being active seems like a more accurate representation. To maintain the previous behavior of counting verified findings, I kept the count and added a link to the query:
This PR also changes how endpoints are measured on a given product. Instead of counting vulnerable hosts / endpoints based on the status of findings, they will now be based on the status of an endpoint statuses. Fixes #9413
[sc-4752]