-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAPI Specification to Release Assets #9054
Conversation
Contextual Security AnalysisAs DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.
Chat with your AI-powered Security Buddy by typing Install and configure more repositories at DryRun Security |
1c4c13d
to
441e95e
Compare
441e95e
to
8b99500
Compare
@kiblik FYI: I've been working on this from the other side - aka creating way to diff spec files from DefectDojo's API. That's about 80% done and will show changes / breaking changes between any 2 versions of the API spec files. |
I'm using this library - https://github.com/Tufin/oasdiff and am aiming towards a GH action which runs the tools and produces the needed output |
I was planning to use the exact tool :) |
@kiblik TBH, I was focusing on making the tool do what I wanted it to using two spec files I pulled from locally running instances of DefectDojo. I think your idea of storing them with a release makes perfect sense to me. Like I said, I'd not thought about that yet but that sounds perfectly fine to me. |
@kiblik Is this ready to review/approve? |
Yes, it is :) |
|
||
- name: Upload Release Asset - OpenAPI Specification - YAML | ||
id: upload-release-asset-yaml | ||
uses: sekwah41/upload-release-assets@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to use this fork over actions/upload-release-asset
? I know the official one is archived but I'm a little hesitant to use a random fork here..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to use this fork over
actions/upload-release-asset
? I know the official one is archived but I'm a little hesitant to use a random fork here..
As I remember, there is no other reason (only stopped maintenance).
If you prefer, I can run a local test with the original official one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I'm doing sth wrong but I'm not able to make it work with actions/upload-release-assets
- https://github.com/kiblik/django-DefectDojo/actions/runs/7188225312/job/19577606201
- https://github.com/kiblik/django-DefectDojo/actions/runs/7188488164/job/19578368890
Any help is welcome
e621912
to
2edc4af
Compare
2edc4af
to
25e9b9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
In the future, I would like to add API changes to release notes. As preparation, I would like to release OpenAPI Specifications with each release as assets.