Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setEnv): remove debug from list #11374

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Dec 4, 2024

debug env was removed in #10692
The selector needs to be removed as well.
Until now, ./docker/setEnv.sh was showing debug as an available option:

$ ./docker/setEnv.sh        
Using 'release' configuration.
-> You can switch to 'dev' with './docker/setEnv.sh dev'
-> You can switch to 'debug' with './docker/setEnv.sh debug'
-> You can switch to 'unit_tests' with './docker/setEnv.sh unit_tests'
-> You can switch to 'integration_tests' with './docker/setEnv.sh integration_tests'

@github-actions github-actions bot added the docker label Dec 4, 2024
Copy link

dryrunsecurity bot commented Dec 4, 2024

DryRun Security Summary

The pull request updates the setEnv.sh script to remove the "debug" environment, simplify the environment list, and ensure consistent environment handling when switching between environments, without introducing any obvious security concerns, but the overall application context should be reviewed to ensure proper security measures for the environment management process.

Expand for full summary

Summary:

The code changes in this pull request are related to the setEnv.sh script, which is responsible for managing the different environment configurations for a Docker-based application. The key changes include the removal of the "debug" environment, simplification of the environment list, and ensuring consistent environment handling when switching between environments.

From an application security perspective, the changes do not seem to introduce any obvious security concerns. The script is primarily responsible for managing the different environment configurations and does not appear to handle any sensitive data or perform any security-critical operations. However, it's important to review the overall context of the application and ensure that the environment management process is properly secured, including the secure storage of environment-specific configuration files, access control, and logging and monitoring of any changes to the environment configuration.

Files Changed:

  • docker/setEnv.sh: This script has been updated to remove the "debug" environment from the list of available environments, simplifying the environment list to "dev", "unit_tests", "integration_tests", and "release". The code also ensures that the corresponding Docker Compose override file is correctly linked or removed when switching between environments, maintaining a consistent environment setup for the application.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch merged commit 4b48bdd into DefectDojo:bugfix Dec 11, 2024
72 checks passed
@kiblik kiblik deleted the setenv_debug branch December 11, 2024 20:26
paulOsinski pushed a commit to paulOsinski/django-DefectDojo that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants