Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs maintenance: remove external images, article updates #11341

Closed
wants to merge 27 commits into from

Conversation

paulOsinski
Copy link
Contributor

@paulOsinski paulOsinski commented Nov 27, 2024

This PR is intended to move externally hosted images into the main repo, along with the following docs updates:

File Changes

  • replace all externally hosted images with images on the repo, and update all image refs to use those hosted images

Article Changes

  • Add Universal Importer / Dojo-CLI docs
  • update DefectDojo Pro Changelog (these changes have already been implemented in Master via this commit)
  • rework Request A Trial article with updated language
  • QA + update articles in Cloud Manager directory

[sc-8918]
[sc-9103]

Copy link

dryrunsecurity bot commented Nov 27, 2024

DryRun Security Summary

The provided text indicates that there are no code changes or files changed to summarize, and the application security engineer is ready to review any future code changes that may be provided.

Expand for full summary

Summary:

There are no code changes provided in the input, so I do not have any specific changes to summarize. As an application security engineer, I would typically review any code changes to ensure they do not introduce any security vulnerabilities or unintended consequences. Without any code changes to analyze, I cannot provide a detailed summary. However, I am ready to review any future code changes that may be provided.

Files Changed:

There are no files changed in the input provided.

Code Analysis

We ran 9 analyzers against 30 files and 0 analyzers had findings. 9 analyzers had no findings.

View PR in the DryRun Dashboard.

@github-actions github-actions bot added the docs label Nov 27, 2024
@paulOsinski paulOsinski changed the title Docs images docs maintenance: remove external images, article updates Nov 27, 2024
@paulOsinski paulOsinski changed the title docs maintenance: remove external images, article updates Docs maintenance: remove external images, article updates Nov 27, 2024
@mtesauro
Copy link
Contributor

Follow on to #11258

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@paulOsinski
Copy link
Contributor Author

some of these filenames were going to break Windows builds as per issue: #11366

I have fixed those references but I imagine I will have to rebase once this hotfix is accepted: #11368

@paulOsinski paulOsinski changed the base branch from dev to bugfix December 4, 2024 22:16
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@paulOsinski paulOsinski closed this Dec 4, 2024
@paulOsinski
Copy link
Contributor Author

I tried to fix this PR but ended up making things much worse, so I am closing this and retrying here: #11376

Sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants