Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct broken documentation links #11178

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

paulOsinski
Copy link
Contributor

Updating broken links in documentation

@github-actions github-actions bot added the docs label Nov 1, 2024
Copy link

dryrunsecurity bot commented Nov 1, 2024

DryRun Security Summary

The pull request updates the links in the "Installation" section of the DefectDojo application documentation to point to the correct URLs for the "SaaS" and "AWS AMI" installation options.

Expand for full summary

Summary:

The code changes in this pull request appear to be updating the links in the "Installation" section of the documentation for the DefectDojo application. The changes are focused on updating the links for the "SaaS" and "AWS AMI" installation options to point to the correct URLs. From an application security perspective, these changes do not introduce any significant security risks, as they are primarily updating documentation and configuration information. However, it's always important to review any changes to the documentation or configuration of an application, as they can sometimes inadvertently introduce security vulnerabilities or expose sensitive information. In this case, the changes seem straightforward and do not raise any immediate security concerns.

Files Changed:

  • docs/content/en/getting_started/installation.md: This file contains the installation instructions for the DefectDojo application. The changes in this pull request update the links for the "SaaS" and "AWS AMI" installation options to point to the correct URLs.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@paulOsinski paulOsinski changed the base branch from dev to bugfix November 1, 2024 20:35
cneill
cneill previously requested changes Nov 1, 2024
docs/content/en/getting_started/architecture.md Outdated Show resolved Hide resolved
Co-authored-by: Charles Neill <1749665+cneill@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your fork is a little old. A given branch on your fork can be quickly synced with the "sync" button
image

I wish this was a thing when I was learning git 😅

Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Maffooch Maffooch dismissed cneill’s stale review November 4, 2024 16:19

The code in question here was related to basing the broken-links branch on an old version of bugfix. Once the newer version of bugfix was merged into broken-links the code in this review was no longer present. Dismissing so that we can merge

@Maffooch Maffooch merged commit 1b68cbe into DefectDojo:bugfix Nov 4, 2024
73 checks passed
@paulOsinski paulOsinski deleted the broken-links branch November 27, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants