-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(helm): add documentation about installation and external databas… #11015
Conversation
DryRun Security SummaryThe pull request primarily focuses on updating the documentation for the DefectDojo application's Kubernetes deployment, including changes to the Helm repository URL, instructions for using an external PostgreSQL database, and expanded documentation for high availability deployment, TLS configuration, and Prometheus metrics, which promote more secure and reliable deployment practices. Expand for full summarySummary: The changes in this pull request primarily focus on updating the documentation for the DefectDojo application's Kubernetes deployment. The key changes include:
From an application security perspective, these changes are positive as they promote more secure and reliable deployment practices. The use of an external PostgreSQL database and the creation of a Kubernetes secret for storing credentials are good security practices. Additionally, the expanded documentation for high availability and monitoring will help ensure the overall security and stability of the deployed application. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
It might be better to place it into https://github.com/DefectDojo/django-DefectDojo/blob/dev/readme-docs/KUBERNETES.md (it is the place described in the official documentation: https://documentation.defectdojo.com/getting_started/installation/#kubernetes)
|
PR should point to |
@leofvo kiblik is correct here - we only take PRs against the dev or bugfix branches. This seems like a dev branch type of PR IMHO. |
I edited to target branch as |
hey, I just merged the readme in the docs, and created a symlink to explicit the documentation location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor request to change the comments on lines 443, 444 to say your database user and your database name
documentation is mentionning values differents from values.yml recommandations, I used the one recommanded. removed DD_DATABASE_URL as it is not specified in values and used HOST and PORT
775741d
to
26bc11e
Compare
Hello,
After installing the helm chart and set up an external database connection, I feel like it's a bit tricky, and we could make it more straight forward with a little documentation.
So I wrote the documentation from my own experience installing the helm chart and set up an external database.
Feel free to give feedback.